problem saving files from 4 axes into a folder

hello, i have codes for saving files from axes to a folder named Citra Latih and also the path of the folder will be saved into mysql. but there is an error, it says:

Error in inputcitra>buttonsimpan_Callback (line 352)
    imwrite(Image1,baseFileName1,'bmp','WriteMode','append');

here is the codes:

function buttonsimpan_Callback(hObject, eventdata, handles)
S=get(handles.txtnama,'String');
if isempty(S)
    msgbox('Harap isi Nama terlebih dahulu','PERINGATAN','warn');
else
    S = get(handles.edit1, 'string');
    file = char(S);
    W = get(handles.txtnama, 'String');
    save('file','W');
    tanggal=get(handles.txttanggal,'String');

      Frame1 =getframe(handles.axes1);
      Image1 = frame2im(Frame1);

      Frame2 =getframe(handles.axes2);
      Image2 = frame2im(Frame2);

      Frame3 =getframe(handles.axes3);
      Image3 = frame2im(Frame3);

      Frame4 =getframe(handles.axes4);
      Image4 = frame2im(Frame4);

      folder = 'F:\Skripsi\Citra Latih';

      filepattern=fullfile(folder, '*.bmp');
      files=dir(filepattern);
      numberoffiles=length(files);

      baseFileName1 = char(['F:\Skripsi\Citra Latih\',num2str(numberoffiles+1),'.bmp']);
      imwrite(Image1,baseFileName1,'bmp','WriteMode','append');

      baseFileName2 = char(['F:\Skripsi\Citra Latih\',num2str(numberoffiles+2),'.bmp']);
      imwrite(Image2,baseFileName2,'bmp','WriteMode','append')

      baseFileName3 = char(['F:\Skripsi\Citra Latih\',num2str(numberoffiles+3),'.bmp']);
      imwrite(Image3,baseFileName3,'bmp','WriteMode','append')

      baseFileName4 = char(['F:\Skripsi\Citra Latih\',num2str(numberoffiles+4),'.bmp']);
      imwrite(Image4,baseFileName4,'bmp','WriteMode','append')

       conn=database('database','root','','com.mysql.jdbc.Driver','jdbc:mysql://localhost:3306/');
       id1 = str2num(get(handles.txtid, 'String'));
       id2=id1+1;
       id3=id2+1;
       id4=id3+1;
       gabung=get(handles.txtnama, 'String');
       nama1 = ([gabung,'-LATIH-A']);
       nama2 = ([gabung,'-LATIH-B']);
       nama3 = ([gabung,'-LATIH-C']);
       nama4 = ([gabung,'-LATIH-D']);
       alamat1 = baseFileName1;
       alamat2 = baseFileName2;
       alamat3 = baseFileName3;
       alamat4 = baseFileName4;
       %foto = get(handles.txtlokasi, 'String');
       tanggal = get(handles.txttanggal, 'String');

       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id1, nama1, alamat1, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id2, nama2, alamat2, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id3, nama3, alamat3, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id4, nama4, alamat4, tanggal});

       close(conn);

       msgbox('Citra Latih berhasil disimpan','BERHASIL','warn');

      set(handles.buttontemplate,'Enable','off');
      set(handles.buttonnormal,'Enable','off');    
      set(handles.buttondeteksi,'Enable','off');
      set(handles.buttonpilih,'Enable','on');
      set(handles.txttanggal,'String',(datestr(date, 'yyyy-mm-dd')));
      cla(handles.axes1);
      cla(handles.axes2);
      cla(handles.axes3);
      cla(handles.axes4);

      conn=database('database','root','','com.mysql.jdbc.Driver','jdbc:mysql://localhost:3306/');
      setdbprefs('NullNumberWrite', 'NaN');
      SQL=['select max(id) from irismata'];
      curs = exec(conn,SQL);
      curs = fetch(curs);
      mydata=curs.Data;
      a = cell2mat(mydata);
      for ii = (a(1)+0):(a(1)+1)
      fn = (num2str(ii,'%i'));
      set(handles.txtid, 'String', fn);
      end
  end

Answer 1

[Walter Roberson]

It would be cleaner to use

        baseFileName1 = fullfile(folder, [num2str(numberoffiles+1),'.bmp'] );

However, you real problem is that 'WriteMode', 'append' is supported only for: GIF, HDF4, and TIFF. You cannot append to BMP.

[Glenn]

so what should we use instead? by the way, is it correct to save binary template into bmp file? if not, could it be saved into tif file?

[Walter Roberson]

"is it correct to save binary template into bmp file?"

According to the imwrite documentation,

"BMP, PNG, or TIFF formats accept binary images as input arrays."

On the other hand, the output of frame2im() is never a binary image.

"so what should we use instead?"

You have not defined a goal: why are you trying to append to the image file?

Suppose that we were able to trick imwrite() into appending the image to a .bmp file, then how would you use the file afterwards? BMP format does not define any way to store multiple images in a file, so no viewer would be able to examine the result.

[Glenn]

to be honest i dont know sir, i didnt completely understand about the codes. my goal is to save 4 binary images into a folder and its path into mysql to do template matching later. this images will be stored in a folder as iris template database. what should i do so it saved as a binary template that can be used for template matching? by the way i've saved the image into tif file and stored it in a folder, and the file path saved into mysql. but there is other problem. when i try to save other 4 files, like repeat the saving process, its overwrited the recent files in the folder, but the path in the myslq updated. like in the mysql there are path for 8 images(first 4 and new 4) but in the folder just 4 new image. the first 4 are gone because it has the same name with the new 4 i guess. (1.tif, 2.tif, 3.tif and 4.tif) how to fix this?

[Walter Roberson]

If your goal is to use template matching, then it is important that you save the actual data that you are displaying, instead of capturing a picture of what the axes looks like and saving that.

For example,

h = getimage(handles.axes1);
Image1 = get(h, 'CData');     %retrieves image that was asked to be displayed

To avoid overwriting files, you could use something like

tmp_name = tempname(folder);
baseFileName1 = [temp_name '_1.bmp'];
imwrite(Image1, baseFileName1);

And you could rewrite your code in terms of a loop:

axhandles = [handles.axes1, handles.axes2, handles.axes3, handles.axes4];

for K = 1 : 4
   h = getimage(axhandles(K));
   imdata = get(h, 'CData');
   baseFileName{K} = sprintf('%s_%d.bmp', temp_name, K);
   imwrite(imdata, baseFileName{K});
end

and then you can send baseFileName{:} to your database.

The disadvantage of this is that it is not at all clear which file was generated from which original iris. If you are starting with iris image file names, you should consider using the input file name to create the output file names.

[Glenn]

i entered the name of the files before save it tho, on text field: txtnama. but its just saved for image name in mysql, not for image that saved in folder. btw is this codes correct? it says:

Error using matlab.graphics.Graphics/get There is no CData property on the Root class.

Error in inputcitra>buttonsimpan_Callback (line 336) Image1 = get(h, 'CData'); %retrieves image that was asked to be displayed

[Walter Roberson]

You do not need to do all of the

h = getimage(handles.axes1);
Image1 = get(h, 'CData');     %retrieves image that was asked to be displayed

individually. You can just use the loop I posted.

However, it appears that your handles.axes1 is not an axes and it appears that you are using R2014a or earlier.

Please show your plotting commands that put the data onto handles.axes1

[Glenn]

im using r2016a tho. its an axes sir. here is the m file.

[Walter Roberson]

You already have code in other routines such as

data1 = get( findobj(handles.axes1, 'type', 'image'), 'CData')

you can do the same thing instead of using getimage()

You also have code that uses setappdata() to store some of the calculated images as properties of the axes. If you want to be saving those, you should retrieve them using getappdata()

You should decide upon one way of storing the data and stick with it, instead of using three different ways.

Unfortunately I have no idea what the normal order of pushing the buttons would be, so that makes it difficult for me to figure out which values have been saved, and which have not, and to figure out what would be displayed at the time you would be doing the saving.

[Glenn]

there are 4 processes using 4 buttons before saving it.

1. load 4 images(using buttonpilih)
2. detect iris(using buttondeteksi)
3. crop the iris(using buttonnormal)
4. generate the template from cropped iris image(using buttontemplate), and save it with buttonsimpan.

actually i wanna save the values from this process (generated template):

function buttontemplate_Callback(hObject, eventdata, handles)
norm=getappdata(handles.axes1,'normalImg');
[temp th tv]=gen_templateVVV(norm);
axes(handles.axes1);imshow(temp);

norm=getappdata(handles.axes2,'normalImg');
[temp th tv]=gen_templateVVV(norm);
axes(handles.axes2);imshow(temp);

norm=getappdata(handles.axes3,'normalImg');
[temp th tv]=gen_templateVVV(norm);
axes(handles.axes3);imshow(temp);

norm=getappdata(handles.axes4,'normalImg');
[temp th tv]=gen_templateVVV(norm);
axes(handles.axes4);imshow(temp);
set(handles.buttonsimpan,'Enable','on');

how to save it?

[Walter Roberson]

norm=getappdata(handles.axes1,'normalImg');
[temp th tv]=gen_templateVVV(norm);
axes(handles.axes1);imshow(temp);

setappdata(handles.axes1, 'templateVVV', temp);

and so on.

Then in the button that you want to indicate saving,

tmp_name = tempname(folder);

axhandles = [handles.axes1, handles.axes2, handles.axes3, handles.axes4];

for K = 1 : 4
   imdata = getappdata( axhandles(K), 'templateVVV' );
   baseFileName{K} = sprintf('%s_%d.bmp', temp_name, K);
   imwrite(imdata, baseFileName{K});
end

and save baseFileName{:} to the database.

[Glenn]

it says: <<Undefined function or variable 'temp_name'.

Error in inputcitra>buttonsimpan_Callback (line 357) baseFileName{K} = sprintf('%s_%d.bmp', temp_name, K);>>

[Walter Roberson]

tmp_name = tempname(folder);

axhandles = [handles.axes1, handles.axes2, handles.axes3, handles.axes4];

for K = 1 : 4
   imdata = getappdata( axhandles(K), 'templateVVV' );
   baseFileName{K} = sprintf('%s_%d.bmp', tmp_name, K);
   imwrite(imdata, baseFileName{K});
end

... and please stop posting images of source code. I cannot copy and paste lines out of images of code, and I cannot search in images of code. Post the code itself, not a picture of the code.

[Glenn]

ah sorry sir, i tho it would be easier for you to see the codes. btw thats exactly what i put in the save button codes, still it has errors like i said. here is the codes in saving button:

function buttonsimpan_Callback(hObject, eventdata, handles)
S=get(handles.txtnama,'String');
if isempty(S)
msgbox('Harap isi Nama terlebih dahulu','PERINGATAN','warn');
else
S = get(handles.edit1, 'string');
file = char(S);
W = get(handles.txtnama, 'String');
save('file','W');
tanggal=get(handles.txttanggal,'String');

       Frame1 =getframe(handles.axes1);
       Image1 = frame2im(Frame1);

       Frame2 =getframe(handles.axes2);
       Image2 = frame2im(Frame2);

       Frame3 =getframe(handles.axes3);
       Image3 = frame2im(Frame3);

       Frame4 =getframe(handles.axes4);
       Image4 = frame2im(Frame4);

      folder = 'F:\Skripsi\Citra Latih';
      filepattern=fullfile(folder, '*.bmp');
      files=dir(filepattern);
      numberoffiles=length(files);

        tmp_name = tempname(folder);
  axhandles = [handles.axes1, handles.axes2, handles.axes3, handles.axes4];
  for K = 1 : 4
     imdata = getappdata( axhandles(K), 'templateVVV' );
     baseFileName{K} = sprintf('%s_%d.bmp', temp_name, K);
     imwrite(imdata, baseFileName{K});
  end 

      tmp_name = tempname(folder);
      baseFileName1 = [temp_name '_1.bmp'];
      imwrite(Image1, baseFileName1);

      tmp_name = tempname(folder);
      baseFileName2 = [temp_name '_2.bmp'];
      imwrite(Image2, baseFileName2);

      tmp_name = tempname(folder);
      baseFileName3 = [temp_name '_3.bmp'];
      imwrite(Image3, baseFileName3);

      tmp_name = tempname(folder);
      baseFileName4 = [temp_name '_4.bmp'];
      imwrite(Image4, baseFileName4);

       conn=database('database','root','','com.mysql.jdbc.Driver','jdbc:mysql://localhost:3306/');
       id1 = str2num(get(handles.txtid, 'String'));
       id2=id1+1;
       id3=id2+1;
       id4=id3+1;
       gabung=get(handles.txtnama, 'String');
       nama1 = ([gabung,'-LATIH-A']);
       nama2 = ([gabung,'-LATIH-B']);
       nama3 = ([gabung,'-LATIH-C']);
       nama4 = ([gabung,'-LATIH-D']);
       alamat1 = baseFileName1;
       alamat2 = baseFileName2;
       alamat3 = baseFileName3;
       alamat4 = baseFileName4;
       tanggal = get(handles.txttanggal, 'String');

       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id1, nama1, alamat1, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id2, nama2, alamat2, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id3, nama3, alamat3, tanggal});
       datainsert(conn,'irismata',{'ID','Nama','Lokasi','Tanggal'},{id4, nama4, alamat4, tanggal});

       close(conn);

       msgbox('Citra Latih berhasil disimpan','BERHASIL','warn');

      set(handles.buttontemplate,'Enable','off');
      set(handles.buttonnormal,'Enable','off');    
      set(handles.buttondeteksi,'Enable','off');
      set(handles.buttonpilih,'Enable','on');
      set(handles.txttanggal,'String',(datestr(date, 'yyyy-mm-dd')));
      cla(handles.axes1);
      cla(handles.axes2);
      cla(handles.axes3);
      cla(handles.axes4);

      conn=database('database','root','','com.mysql.jdbc.Driver','jdbc:mysql://localhost:3306/');
      setdbprefs('NullNumberWrite', 'NaN');
      SQL=['select max(id) from irismata'];
      curs = exec(conn,SQL);
      curs = fetch(curs);
      mydata=curs.Data;
      a = cell2mat(mydata);
      for ii = (a(1)+0):(a(1)+1)
      fn = (num2str(ii,'%i'));
      set(handles.txtid, 'String', fn);
      end
  end

[Walter Roberson]

function buttonsimpan_Callback(hObject, eventdata, handles)
S = get(handles.txtnama,'String');
if isempty(S)
msgbox('Harap isi Nama terlebih dahulu','PERINGATAN','warn');
else
S = get(handles.edit1, 'string');
file = char(S);
W = get(handles.txtnama, 'String');
save(file, 'W');
tanggal = get(handles.txttanggal,'String');

folder = 'F:\Skripsi\Citra Latih';

tmp_name = tempname(folder);
axhandles = [handles.axes1, handles.axes2, handles.axes3, handles.axes4];
for K = 1 : 4
   imdata = getappdata( axhandles(K), 'templateVVV' );
   baseFileName{K} = sprintf('%s_%d.bmp', tmp_name, K);
   imwrite(imdata, baseFileName{K});
end
     conn = database('database', 'root', '', 'com.mysql.jdbc.Driver', 'jdbc:mysql://localhost:3306/');
     id1 = str2num(get(handles.txtid, 'String'));
     id2 = id1+1;
     id3 = id2+1;
     id4 = id3+1;
     gabung = get(handles.txtnama, 'String');
     nama1 = [gabung,'-LATIH-A'];
     nama2 = [gabung,'-LATIH-B'];
     nama3 = [gabung,'-LATIH-C'];
     nama4 = [gabung,'-LATIH-D'];
     alamat1 = baseFileName{1};
     alamat2 = baseFileName{2};
     alamat3 = baseFileName{3};
     alamat4 = baseFileName{4};
     tanggal = get(handles.txttanggal, 'String');

       datainsert(conn, 'irismata',{'ID','Nama','Lokasi','Tanggal'}, {id1, nama1, alamat1, tanggal});
       datainsert(conn, 'irismata',{'ID','Nama','Lokasi','Tanggal'}, {id2, nama2, alamat2, tanggal});
       datainsert(conn, 'irismata',{'ID','Nama','Lokasi','Tanggal'}, {id3, nama3, alamat3, tanggal});
       datainsert(conn, 'irismata',{'ID','Nama','Lokasi','Tanggal'}, {id4, nama4, alamat4, tanggal});

       close(conn);

       msgbox('Citra Latih berhasil disimpan', 'BERHASIL', 'warn');

      set(handles.buttontemplate, 'Enable', 'off');
      set(handles.buttonnormal, 'Enable', 'off');    
      set(handles.buttondeteksi, 'Enable', 'off');
      set(handles.buttonpilih, 'Enable', 'on');
      set(handles.txttanggal, 'String', datestr(date, 'yyyy-mm-dd') );

      cla(axhandles);

      conn = database('database', 'root', '', 'com.mysql.jdbc.Driver', 'jdbc:mysql://localhost:3306/');
      setdbprefs('NullNumberWrite', 'NaN');
      SQL = 'select max(id) from irismata';
      curs = exec(conn,SQL);
      curs = fetch(curs);
      mydata = curs.Data;
      a = cell2mat(mydata);
      for ii = (a(1)+0) : (a(1)+1)
        fn = num2str(ii, '%i');
        set(handles.txtid, 'String', fn);
      end
  end

Spaces cost about 10^(-8) cents each, but make the code much more readable. Use them.

[Glenn]

thank you sir, it works. :) by the way, how to make the file name is from text field that we input before we save it? so it will be named as like alfio-1, alfio-2, alfio-3, alfio-4 instead of named as random string+1 until 4? the text field to enter the name in this code is txtnama.

[Walter Roberson]

Change

tmp_name = tempname(folder);

to

tmp_name = fullfile(folder, get(handles.txtnama, 'string') );

[Glenn]

Thank you so much, sir. You are so magical! :D