Rank: 8905 based on 0 downloads (last 30 days) and 0 file submitted
Personal Profile:
Professional Interests:

 

Watch this Author's files

 

Comments and Ratings by Donn View all
Updated File Comments Rating
09 Sep 2011 mparser A matlab lexer and parser written with ANTLR, with a mex interface. Author: David Wingate

There may be several reasons why a rating of lower than five should be given to this submission, however, David has clearly stated that this is a preliminary version of the parser. He has given us a commented grammar with notes on how to produce either the mex parser that he uses or a java parser which can be debugged using the tools from the antlr website.

I would encourage the use of H1 help lines in the m files to be in line with MATLAB normal coding standards, and facilitate the use of lookfor, etc. There is a lot of information on making good help text for m files. You can find it in the MATLAB documentation, in the style guidelines by Richard Johnson posted on the file exchange, or better yet in Richard Johnsons book "The Elements of MATLAB style.

Again a good effort which will be useful for someone developing MATLAB tools.

29 Aug 2011 factoriel how to calculate the factoriel of an integer Author: Ali

There are several ways to improve this submission. I am sure people will probably give this a low rating because it has no H1 line or help text of any kind. The name of the file will make it hard to find if you re trying to find it long after you have written it. Obviously MATLAB has a builtin factorial function. Therefore I assume this file is written to demonstrate the technique of computing a factorial. As such it should be noted that the variable y is not needed the else portion could have been written as:

d=1;
for k=1:m
d=d*k;
end

or to demonstrate a more effective use of MATLAB you could have used

d = prod(1:m);

In the past the file exchange had a wiki with guidelines on how to create a select submission. It is too bad that it is no longer available. You can still look at example m files from The MathWorks, and The MathWorks documentation on how to properly add help text to a file including a nicely formatted first line (known as the H1 line) to help users that may be interested in your file.

06 Jun 2010 print a gif in matlab printgif prints gif files in matlab Author: Ben Barrowes

Hi Ben,

This is a nicely written file with good help, an H1 line and helpful comments in the code. I have a few suggestions if you want to make your function a little more like a MathWorks function.

You may wiant to consider changing the name. When I first saw your submission I thought it was for sending a gif file to a printer. Some alternate names might be fprintgif, writegif, or imwritegif.

Your file has an all lowercase name. This is the standard case for MathWorks api functions. The MathWorks uses an uppercase version of the function name on the H1 line without the argument list. This makes the H1 line stand out and without the arguments list there is more room for the description on the H1 line.

The MathWorks help usually follows the H1 line with some form of syntax help for calling the function and descriptions of the required inputs. You may want to consider explicitly naming the required inputs figure, and filename and checking that they are correct and then explaining them in the help.

The MathWorks includes a See Also section in their help. In this case you may want to reference print, imread, and imwrite.

Your help text is indented one space more than what The MathWorks uses.

These are all just suggestions.

Donn

Contact us