I had to work out some bugs before the output matched the the pcm (pulse code modulated) samples from the mpg123 decoder.
here are the bugs:
decoder line 117: ms_stereo should be 0 if mode_extension_check == 0
decoder line 278: add1_range should never be set to [0 0]. When region_address1==0 the number of critical bands using the first Huffman table is one more than that. The fist critical should be included in region1 by removing the if statment and keeping the statments under the true condition.
This is poor in several ways. First of all it is a script that starts with: "clc; clear all; in_img = imread('sofa.JPG'); .." Second, it lacks help and comments. Third, it is poorly written: for instance, not pre-allocation and avoidable loops. Finally, it turns color images into an BW oil-paint sketch ...
As it stands, this submission is useless to anyone but the author. Please learn how to write functions that are flexible and do not destroy the users workspace and that contains help!
I had to work out some bugs before the output matched the the pcm (pulse code modulated) samples from the mpg123 decoder.
here are the bugs:
decoder line 117: ms_stereo should be 0 if mode_extension_check == 0
decoder line 278: add1_range should never be set to [0 0]. When region_address1==0 the number of critical bands using the first Huffman table is one more than that. The fist critical should be included in region1 by removing the if statment and keeping the statments under the true condition.
Comment only
10 Feb 2010
Oil Paint Effect
This m file performs an Oil Paint effect on an input image.
This is poor in several ways. First of all it is a script that starts with: "clc; clear all; in_img = imread('sofa.JPG'); .." Second, it lacks help and comments. Third, it is poorly written: for instance, not pre-allocation and avoidable loops. Finally, it turns color images into an BW oil-paint sketch ...
As it stands, this submission is useless to anyone but the author. Please learn how to write functions that are flexible and do not destroy the users workspace and that contains help!
Comment only