Search Comments and Ratings

go

Comments and Ratings

   
Date File Comment by Comment Rating
06 Aug 2009 kmeans clustering Fully vectorized kmeans algorithm. Fast yet simple (10 lines) Author: Michael Chen Sven

This gave a simple implementation to the problem I had.
A couple of notes:
- Reduction of code is good, reduction of comments is not. "litekmeans" is without any header line or comments describing what this (very useful) function does, what kind of input it takes, what it produces etc. Things like the dimension to arrange the input points are necessary to use the function properly, but are not explained in a header. Whether or not the function handles 1D, 2D, 3D, etc data isn't written anywhere.
- Providing data as a data.mat file is useful for functions requiring custom made data, but it tends to obscure the format of the data. It would be simpler and easier to understand by providing equally simple sample code that makes the data.
- Providing brief sample code on the file exchange is fine, but it should be included as a header to the file, so that people can find it when they need it, rather than when they first download it.
Otherwise, thanks! Like I said, it solved my immediate problem.

13 Jun 2009 Hessian based Frangi Vesselness filter Enhancement of Vessel/ridge like structures in 2D/3D image using hessian eigen values Author: Dirk-Jan Kroon Sven

Thank you for this implementation. I had just begun to try to implement this myself, and your solution has been very helpful.

07 Jan 2009 Detects multiple disks (coins) in an image using Hough Transform HOUGHCIRCLES detects multiple disks (coins) in an image using Hough Transform. Author: Yuan-Liang Tang Sven

Nice function. Code is well documented and clearly written.
One suggestion is to follow the example of the peaks() function: if no output argument is given, then create a figure and display the image. If it's used with an output argument, assume the user is embedding the function in their own code, and doesn't want a figure to come up automatically.

25 Nov 2008 Recursive addpath Recursively adds directories to MATLAB path, optionally ignores some Author: Anthony Kendall Sven

You can avoid the first bug I mentioned above by adding the following at line 59:
currDir = currDir([currDir.isdir]);

Oh, and I just checked in genpath, and see that IT uses recursive calls to 'dir'. Therefore my second suggestion doesn't actually avoid these multiple calls!

25 Nov 2008 Recursive addpath Recursively adds directories to MATLAB path, optionally ignores some Author: Anthony Kendall Sven

Thank you for this very useful function. I have two main comments:
1. I think that there's a bug that causes the function to crash if a file without ANY extension is in a directory. For example, some people submit file exchange packages that include a file called "README". Your function fails on this case (at the moment).

2. I haven't checked yet, but perhaps this could be rewritten without using recursive functions. I think that if you simply use genpath to get a list of directories, you could then filter this list all in one go. This may be a little faster.

Nice function!

 

MATLAB Central Terms of Use

NOTICE: Any content you submit to MATLAB Central, including personal information, is not subject to the protections which may be afforded information collected under other sections of The MathWorks, Inc. Web site. You are entirely responsible for all content that you upload, post, e-mail, transmit or otherwise make available via MATLAB Central. The MathWorks does not control the content posted by visitors to MATLAB Central and, does not guarantee the accuracy, integrity, or quality of such content. Under no circumstances will The MathWorks be liable in any way for any content not authored by The MathWorks, or any loss or damage of any kind incurred as a result of the use of any content posted, e-mailed, transmitted or otherwise made available via MATLAB Central. Read the complete Terms prior to use.

Contact us at files@mathworks.com