Search Comments and Ratings

go

Comments and Ratings

   
Date File Comment by Comment Rating
23 Nov 2009 A manual code for image THRESHOLDING (or) Color to binary image conversion This file convert any image into a binary format Author: Rama Chandra Rao Naradasu Anon

see http://www.mathworks.com/matlabcentral/fileexchange/25929-general-dilation-code for comment

23 Nov 2009 General dilation code It is a simple code on dilation operation works good Author: Rama Chandra Rao Naradasu Anon

Uuuh (shudder)... there are so many shortcomings that I just don't know where to start...

1. it's a script and not a function
2. uses clc and clear all at the beginning
3. tries to read an image that has not been supplied with the submission (dil.jpg)
4. unnecessary use of nested loops
5. no preallocation
6. no comments
7. no help
8. tries to index in variables that have not been created before
9. and so on...

Please remove.

07 Oct 2009 Normalize Array Row Wise Each array is normalized such that rows sum to 1 Author: Shivani Rao Anon

could be solved more efficiently by calling bsxfun...

A = magic(4);
An = bsxfun(@rdivide,A,sum(A,2));

14 Aug 2009 Conic Plotter Plots conics given as implicit functions Author: creek Anon

"I decided to write a review about FEX @Matlab" [... and ...] "start submitting it to every review journal/magazine on the Internet"

Do it, if you have the time. But I suggest you better use your valuable time to explore the FEX. There are great utilities around here, you'll find awesome software and kind people always willing to help. You will see people with a lot of experience, whose ratings you can rely on. And you will see that there is a huge amount of useless and flawed software. In my opinion it is not easy to filter the good things out. That's why I am happy with the rating system and grateful to the experts that take the time to give (imo) fair ratings.

You didn't have a very good start here. You rated your own file with five stars which is condemned here.

19 Jun 2009 Matrix to file Writes matrix to a file. Arguments: matrix and file-name Author: Nicolai Sten Anon

When you and others experienced this problem with finding dlmwrite, than this should encourage you to take even more care to give a good documentation for your function.

A good documentation should provide an H1-line (the very first line in the help block of your function)
http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/matlab_prog/f7-41453.html&http://www.google.ch/search?q=h1+line+mathworks&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:de:official&client=firefox-a

, a good description and syntax of the function. Moreover, providing an example of the function usage is always a good help for others.

dlmwrite might be difficult to find, yet, once found, it still provides a more powerful tool than this function due to its flexibility. Still, it lacks some features such as adding header lines/column names or supporting cell arrays. I'd like to see, that you should built upon these shortcomings and include such functionalities (in case you have the time to do so).
  

16 Jun 2009 Matrix to file Writes matrix to a file. Arguments: matrix and file-name Author: Nicolai Sten Anon

Why do you submit a function that already exists? This function does only a subset of what dlmwrite can do. You may want to improve this function so that it can write cell arrays with mixed data types. Yet, I am quite sure that something like this already exists on the FEX. Moreover, this submission lacks reasonable help and an H1 line. Sorry, but so far I don't see much value in this submission.

15 Jun 2009 export matlab data to excell A simple function to export data to excel. The function writes a CSF text file. Author: Sherif Omran Anon

"Please don't send me emails with questions because i don't have time to reply. Try to find the answer online. This function is very simple and don't need questions to be asked. "

You have no time to write emails?? Well, than you should take the time to write a proper help for this function. True, the function is simple and some people might find it useful and use it. Still, be a friendly software developer that does not force the user to look through the source code (no matter how short it is).

15 Apr 2009 Demirel Edge Detector A new fast and cool edge detector! Author: Shahab Anbarjafari Anon

Rename it to "outerperim" or something like this or ... just remove it.

14 Apr 2009 ILC Instants Letters Combinations Author: PXlab Anon

24 Feb 2009 Demirel Edge Detector A new fast and cool edge detector! Author: Shahab Anbarjafari Anon

Try this and you will see, that this is not an edge detector.

A = repmat(linspace(0,1,200),400,2);
h = demirel(A,0.5,1);
subplot(1,2,1); imshow(A); title('One edge in the original image')
subplot(1,2,2); imshow(h,[]);
title('mmmh...three edges here... strange... Why?')

20 Feb 2009 a better code for LDA based face recognition I have modified the former code so that it runs faster and can be run on normal PCs. Author: Shahab Anbarjafari Anon

When this script is "better", why not update the existing LDA file? Have you never heard of the update function?

This file needs major revision. As it stands right now, it is useless. It is a script and not a function

clc
clear all
close all
clear memory

It reads an image that is not supplied with this function.

And again: Why do you repeatedly clear the variable memory that does not exist. Or does the command clear memory make sense? Correct me if I am wrong. As it stands right now, the script is only useful to you. Since there is no help, it does not even have educational purpose.

09 Jan 2009 Couple Serial and parallel way in a couple mechanism. Author: PXlab Anon

after a quick run of your program, my command was simply

delete couple.m

no further comment...

13 Dec 2008 Implementation of Shortest Route framed in GUI This algorithm will find out the Shortest Route in the network Topologies. Author: Ranjit Anon

Shortest_route returns an error when called. May be you forgot to submit the Shortest_route.fig file. But, please, before you resubmit, please add a more informative help to your m-file. As it stands now, I only know from the text above, that a adjacency matrix is required.

>> Shortest_route
??? Error using ==> load
Unable to read file Shortest_route.fig: No such file or directory.

Error in ==> hgload at 43
fileVars = load(filename,'-mat');

Error in ==> openfig at 72
    [fig, savedvisible] = hgload(filename, struct('Visible','off'));

Error in ==> gui_mainfcn>local_openfig at 286
    gui_hFigure = openfig(name, singleton, visible);

Error in ==> gui_mainfcn at 159
        gui_hFigure = local_openfig(gui_State.gui_Name, gui_SingletonOpt, gui_Visible);

Error in ==> Shortest_route at 19
    gui_mainfcn(gui_State, varargin{:});

12 Dec 2008 Fibonacci The following function generate the fibinacci series up to the sequence number m. Author: Shahab Anbarjafari Anon

Why going for recursion, when there are other ways to solve it?

Your function:
>>tic;a = fibonacci(30);toc
Elapsed time is 57.611550 seconds.
>> a

a =

      832040

David Terr's function
http://www.mathworks.com/matlabcentral/fileexchange/5093

>> tic;a = fibonacci2(30);toc
Elapsed time is 0.000082 seconds.
>> a

a =

      832040

12 Dec 2008 N Even solution of odd-even input. Author: PXlab Anon

Shabab, I am somewhat surprised and disappointed. I gave an honest and careful review on your file ( http://www.mathworks.com/matlabcentral/fileexchange/22233 ) but you despise my efforts because you expected a higher rating. Well, if so, then everyone should get a perfect rating and everyone is happy, although at the cost of a decreasing quality of the FEX. I used to rely on ratings on files in order to not always have to judge myself programming correctness, efficiency etc. Well, it will turn out that I only trust FEX long-time residents like John D'Errico, Jos, us, ... who hopefully keep contributing. But that's bad for newcomers, so also for you, who deserve a chance.

08 Dec 2008 MATLAB colors database All Matlab images inside a 3D box. Author: PXlab Anon

08 Dec 2008 MATLAB colors database (2° version) A serial-parallel soluction of the 301 image-memorizations. Author: PXlab Anon

01 Dec 2008 Falt Fading Channel Simulate the BER of a QPSK modulated siganal using an AWGN channel with flat rayleigh fading. Author: Shahab Anbarjafari Anon

Beware! This script clears your workspace. There is hardly any help, so this is valuable for nobody except the author. Make it a function, provide better help and comment your code.

25 Nov 2008 maxima and minima M-files for obtaining extreme points is a set of data Author: aasim Azooz Anon

I agree with Duane,
I wouldn't like to search a pdf first before being able to use a function. You?

25 Nov 2008 Demirel Edge Detector A new fast and cool edge detector! Author: Shahab Anbarjafari Anon

Hi Shabab,

no, it's not new. I'd not even call it edge detection. Your code identifies objects simply by grayscale to bw image conversion using a threshold. Identifying the edge around objects in a logical matrix is really trivial. Look at the function bwperim. It does what your function does except one but important difference.

bwperim
"A pixel is part of the perimeter if it is nonzero and it is connected to at least one zero-valued pixel."

the output of your function could be described as
"A pixel of the output is part of the edge if it is zero and it is connected to at least one one-valued pixel." + that you can enhance the width of the edge.

So what is an edge? The inner perimeter or the outer perimeter of an object? Your function returns the outer perimeter of objects and it should be named so.

Would that be new? No. See for example
http://www.mathworks.com/matlabcentral/fileexchange/12303

25 Nov 2008 Demirel Edge Detector A new fast and cool edge detector! Author: Shahab Anbarjafari Anon

Hi Shabab,

same happened to me once. The immediate submission of a rating by just clicking one of the stars is really annoying.

Still, I looked at your files and there are some things I want to address.

First, there are no H1-lines. This first line in your function help block is supported by the function lookfor.

Second, what is the function demireledge good for except that it passes the variables to demirel , clears the variable memory (what do you want to do with the command clear memory?), if there is any, and clears your command window.

Third, I look at the function demirel. The function syntax in the help text does not say anything of a third input variable T, which, however, is required to run the function. demirel applies edge detection to binary images, but allows for rgb images, too, by simply converting them to grayscale with the function rgb2gray and then to binary with im2bw. You should refer to this mechanism in your help text.

When you create the Kernel, you apply the variable T. What, if the user supplies a thickness of 0.1? Check the validity of this input argument.

After filtering the bw image with a cross shaped kernel, you set elements in the result Q to zero, if they are less than 1. You accomplish this by
Q([find(Q<1)])=0;
Since logical indexing is allowed, it would be totally sufficient and more effective to write
Q(Q<1) = 0;
But, do you expect any values to be below 1? Given the Kernel and the bw image, this will not occur.

Instead of line 24-27, I'd just write
h = Q>0 & ~im1;
and return h as a logical matrix.

At the end, you apply edge detection to a logical matrix. You calculate edges with specified thickness around objects previously simply identified by thresholding a gray scale image.

What is new about it to give it the name demirel edge detection detection?

25 Nov 2008 Demirel Edge Detector A new fast and cool edge detector! Author: Shahab Anbarjafari Anon

I did not look at the code. But self-rating, though not immediately obvious, is considered not appropriate here.

06 Nov 2008 Serial_Player_Capacitors Serial capacitors like source in a game of dice. Author: PXlab Anon

No, a capacitor indipendent to time is still a capacitor with time. Imagine two capacitors walking side by side. Even without time the second walks faster than the first because their relation is point in the half. If three capacitor, this gets complicated. Because then point of half becomes point of half by half. Yours assumption is wrong. Think of relativity ... capacitor 1 divided by 2 and 3. Realize all of them are equal but with different speeds they become different. Negative velocities will remain as long as you retain your position relative to capacitor 1 2 or 3. You think you know capacitors, but you know only one. You have to beware, because all are different, some dangerous some friendly. Finding a formular of it requires classification in good or bad. But I'm sure, you find the answer. But beware, some female capacitors can be very attractive, and their boyfriend capacitors don't like see you after them.

04 Nov 2008 comparisons a strategy of classification Author: PXlab Anon

There is no video output. What video output?

Please check if the following command runs on your system
a= [];b=1; while a==[]; b =b+1;end

If b = 1 than your while statement is either needless, because the lines inside are never executed, or wrong, if the the lines should be executed.

Still, I don't understand you.

"This program show a strategy of classification. Is a statistics proposal. Is a comparison of two elements."

Now what is it. A classification, a comparison? What are elements? Objects characterized by different variables? Time, shoes and approvals?

Then you define winners

"winner is 1° element or if winner is 2° element"

What is degree here, and why does a classification, if it is one, return a winner?

So, please clarify.

Perhaps, take some TIME, put on your SHOES and think of your algorithm during a nice stroll outside. Then improve your code and, perhaps, then you'll get our APPROVAL.

03 Nov 2008 diceN_classification Classification of a dice-game with N players and N dice and N faces. Author: PXlab Anon

Sometime he'll give a submission and nobody will download...

 

MATLAB Central Terms of Use

NOTICE: Any content you submit to MATLAB Central, including personal information, is not subject to the protections which may be afforded information collected under other sections of The MathWorks, Inc. Web site. You are entirely responsible for all content that you upload, post, e-mail, transmit or otherwise make available via MATLAB Central. The MathWorks does not control the content posted by visitors to MATLAB Central and, does not guarantee the accuracy, integrity, or quality of such content. Under no circumstances will The MathWorks be liable in any way for any content not authored by The MathWorks, or any loss or damage of any kind incurred as a result of the use of any content posted, e-mailed, transmitted or otherwise made available via MATLAB Central. Read the complete Terms prior to use.

Contact us at files@mathworks.com