dicominfo bug?

Ofek Shilon — Tue, 02 Jan 2007 12:54:03 -0500

Note to dicom function users (and authors?)

I recommend the following modification to dicominfo code
go to the function getItemNames on line 554 of dicominfo,
and replace it with the following code:

%%%%%%%%% start snipping:
function itemNames = getItemNames(numberOfItems)

% Create a cell array of item names, which can be quickly used.
persistent namesCell maxItemsPreStored
if (isempty(namesCell))

    maxItemsPreStored = 300;
    namesCell = cell(1, maxItemsPreStored);
    for idx = 1:maxItemsPreStored
        namesCell{idx} = sprintf('Item_%d', idx);
    end

end

% Return the first n item names.
if numberOfItems <= maxItemsPreStored
    itemNames = namesCell(1:numberOfItems);
else % slow but necessary fallback
    itemNames = cell(1, numberOfItems);
    for idx = 1:numberOfItems
        itemNames{idx} = sprintf('Item_%d', idx);
    end
end
%%%%%%%%% snip end

the original code lacks a fallback for the case of more than 300
items - which is not too rare, e.g. in DICOMDIR files.

Ofek

Re: dicominfo bug?

Jeff Mather — Thu, 04 Jan 2007 13:05:35 -0500

Ofek Shilon wrote:
>
> the original code lacks a fallback for the case of more than 300
> items - which is not too rare, e.g. in DICOMDIR files.

We just recently fixed this in our code base. A fix will appear in a
future release of the Image Processing Toolbox. The attached code
should perform a little better than the previous suggestion.

Jeff Mather
Image Processing Group
The MathWorks, Inc.

%% In toolbox/images/medformats/dicominfo.m

function itemNames = getItemNames(numberOfItems)

% Create a cell array of item names, which can be quickly used.
persistent namesCell
if (isempty(namesCell))
     namesCell = generateItemNames(50);
end

% If the number of cached names is too small, expand it and recache.
if (numberOfItems > numel(namesCell))
     namesCell = generateItemNames(numberOfItems);
end

% Return the first n item names.
itemNames = namesCell(1:numberOfItems);

function namesCell = generateItemNames(numberOfItems)

namesCell = cell(1, numberOfItems);
for idx = 1:numberOfItems
     namesCell{idx} = sprintf('Item_%d', idx);
end

MATLAB Central Newsreader - dicominfo bug?

dicominfo bug?

Re: dicominfo bug?