Depth of call nesting exceeds threshold

The nesting depth of control structures in a function is greater than the defined nesting depth threshold of a function

Description

This defect is raised when the nesting depth of control structures in a function, such as for, if-else, switch, or while, exceeds the defined nesting depth threshold. For details about how Polyspace^® calculates the nesting depth, see .

Polyspace uses the default threshold 4 unless you specify a threshold. To specify a selection file where you can set the threshold, use Set checkers by file (-checkers-selection-file) (Polyspace Bug Finder Server). Also see Reduce Software Complexity by Using Polyspace Checkers (Polyspace Bug Finder Server).

When you import comments from previous analyses by using , Polyspace copies any review information on the code metric in the previous result to this checker in the current result. If the current result contains the same code metric, the review information is copied to the code metric as well.

Risk

Violation of this checker might indicate that:

• The function is difficult to read and understand.

• The function performs too many tasks at once.

• The function contains unexpected or unplanned development.

These factors make the module difficult to maintain and debug.

Fix

To fix this check, either refactor your code or change the checker threshold. When refactoring your code:

• Design the function to perform a single task.

• Delegate unrelated tasks to other functions.

A best practice is to check the complexity of a module early in development to avoid costly post-development refactoring.

Examples

Avoid Functions That Have Excessive Call Nesting

int foo(int i, int j, int k) //Noncompliant
{
	int m=0;
	for (i=0; i<10; i++)
	{
		for (j=0; j<10; j++)
		{
			for (k=0; k<10; k++)
			{
				if (i < 2 && j>5 && k<7 )
				m += 1;
				else
				{
					if (i > 5 && j<8 && k >8){
						m +=-1 ;	
					}
					
					else{
						m += 2;	
					}
				}
			}
		}
	}
	return m;
}

In this example, the depth of call nesting is 5, which is above the default threshold of 4. The function iterates over three integers and modifies the integer m conditionally. The high depth of nesting makes reading and understanding the function difficult.

Correction — Refactor the Function

One possible correction is to delegate different tasks to different functions. For instance, delegate the conditional actions in foo to another function bar.

int bar(int i, int j, int k){//Compliant
int m = 0;
	if (i < 2 && j>5 && k<7 ){
		m = 1;	
	}
	else
	{
		if (i > 5 && j<8 && k >8){
			m =-1 ;	
		}
		
		else{
			m = 2;	
		}
	}
return m;
}

int foo(int i, int j, int k) //Compliant
{
	int m=0;
	for (i=0; i<10; i++)
	{
		for (j=0; j<10; j++)
		{
			for (k=0; k<10; k++)
			{
				m += bar(i,j,k);	
			}
		}
	}
	return m;
}

Check Information

Group: Software Complexity

Language: C | C++

Acronym: SC14

Default Threshold: 4