how can i fix it please
Show older comments
Answers (2)
Image Analyst
on 9 Apr 2022
Edited: Image Analyst
on 9 Apr 2022
Replace "and" by a double (not single) ampersand : &&
Get rid of lines 4 and 6. MATLAB does not have a "do" and does not start and end blocks with braces.
Your while loop doesn't seem to have any way to exit if it goes into it. How could soc and Ppv change if they're variables? If they're functions, then perhaps they could come back with different values each time, but they're not. They're either scalars or arrays (which is it?).
But there's also a problem in that your while has no failsafe - no limit on the number of iterations so you could get into an infinite loop situation. More robust code would be:
maxIterations = 100000; % Way more than you think you'd ever need.
loopCounter = 0; % The failsafe
while (soc < 80) && (Ppv > 4000) && loopcounter < maxIterations
u = 0;
% Then maybe some other code that changes soc or Ppv.
% Finally increment the loop counter.
loopCounter = loopCounter + 1;
end
if loopCounter >= maxIterations
warningMessage = sprintf('Loop exited early after %d iterations', loopCounter)
uiwait(warndlg(warningMessage));
end
6 Comments
khalil chnini
on 9 Apr 2022
Edited: khalil chnini
on 9 Apr 2022
Image Analyst
on 9 Apr 2022
How does soc or Ppv ever get changed inside the loop?
khalil chnini
on 9 Apr 2022
Image Analyst
on 9 Apr 2022
OK, then you should break out of the loop if/when the criteria gets met.
khalil chnini
on 12 Apr 2022
Edited: khalil chnini
on 12 Apr 2022
Image Analyst
on 12 Apr 2022
Somehow you are changing either soc or Ppv inside the loop. When the condition below
(soc < 80) && (Ppv > 4000) && loopcounter < maxIterations
is false, the loop will automatically exit. You said that you were getting those values inside the loop via asking the user with an input() statement, which is how I interpreted this: "w enter them as an input throu (go to ) block"
Karuppasamy Kalimuthu
on 9 Apr 2022
0 votes
and to be replaced by &
3 Comments
John D'Errico
on 9 Apr 2022
Actually, no. You want to use && in an if statement. There is a difference.
Karuppasamy Kalimuthu
on 11 Apr 2022
Yes. && is correct.
Walter Roberson
on 11 Apr 2022
Either & or && can be used when both sides are scalars, but && would be more efficient in such a case.
If the left side is non-scalar, or the left side is scalar non-zero and the right side is non-scalar, then & must be used instead of && .
Categories
Find more on Matrix Indexing in Help Center and File Exchange
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!