Help with creating a for loop
Show older comments
Can someone help me out with writing a for loop? I'll do my best to explain. So, I need to take the first row of a 20x4096 single and compare it with row 2, then row 3, and then row 4 using cosine similarity where row 1 = x and rows 2 through 4 = y. Then I need to take row 5, compare it with row 6, then row 7, then row 8 and continue that process until I get through all 20 rows. Hopefully that all makes sense. I can provide whatever is needed.
Answers (1)
James Tursa
on 12 Dec 2020
Edited: James Tursa
on 12 Dec 2020
You could take this approach:
A = your matrix
AA = A*A'; % all of the dot products between rows (more than you need, actually)
d = sqrt(diag(AA)); % the norms of the rows
AA = AA ./ d; AA = AA ./ d'; % normalize everything, or AA = AA ./ (d*d');
The result has the cosine similarities between all of the rows. Pick off what you need. E.g., AA(1,2) has the cosine similarity between rows 1 and 2. AA(5,8) has the cosine similarity between rows 5 and 8. Etc.
This does extra computations that you don't need, of course. But by using functions like matrix multiply that are multi-threaded I am guessing it may run faster than custom code that tries to avoid the unnecessary computations. The caveat is if the row size is too large then the memory usage may bog you down.
9 Comments
Christian Basa
on 12 Dec 2020
James Tursa
on 12 Dec 2020
Edited: James Tursa
on 12 Dec 2020
Can't you just run my code and do some spot calculations to satisfy yourself that it works? Why do you need to use for-loops? E.g., compare the following:
AA(1,2) - dot(A(1,:),A(2,:))/(norm(A(1,:))*norm(A(2,:)))
AA(1,3) - dot(A(1,:),A(3,:))/(norm(A(1,:))*norm(A(3,:)))
AA(5,7) - dot(A(5,:),A(7,:))/(norm(A(5,:))*norm(A(7,:)))
etc.
If you really want a for-loop
for m = 1:4:size(A,1)
for k = m+1:m+3
result(m,k) = dot(A(m,:),A(k,:)) / (norm(A(m,:))*norm(A(k,:)));
end
end
The result should be pretty close to the AA values in the spots that are calculated.
On my machine, the matrix multiply code I posted above runs about 10 times faster than the loops shown for a large matrix, even though the matrix multiply code is calculating many more spots than the looping code.
Christian Basa
on 12 Dec 2020
Edited: Christian Basa
on 12 Dec 2020
James Tursa
on 13 Dec 2020
What is size(A)?
Christian Basa
on 13 Dec 2020
James Tursa
on 13 Dec 2020
Huh? I'm lost. If A is 5x4096 it only has 5 rows. Why are you talking about rows 9, 13, 17?
Christian Basa
on 13 Dec 2020
James Tursa
on 13 Dec 2020
Edited: James Tursa
on 13 Dec 2020
Well, forget variable A. Simply use my code with featuresTest.
I would point out that this is the first time you have bothered to mention to me that you have extracted every 4th row into a separate variable and are trying to work with that. This would have been an important detail to mention up front.
Christian Basa
on 13 Dec 2020
Edited: Christian Basa
on 13 Dec 2020
Categories
Find more on Logical in Help Center and File Exchange
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!