feval error in GUI implementation

I have this code that I have bult that compares a string coming over serial data to one that is stored in an excel file. A correct match makes a panel in the GUI go green, and red when they are not matched.

This is the code I have as of now:

function varargout = WorkingGUI2(varargin)
% WORKINGGUI2 MATLAB code for WorkingGUI2.fig
%      WORKINGGUI2, by itself, creates a new WORKINGGUI2 or raises the existing
%      singleton*.
%
%      H = WORKINGGUI2 returns the handle to a new WORKINGGUI2 or the handle to
%      the existing singleton*.
%
%      WORKINGGUI2('CALLBACK',hObject,eventData,handles,...) calls the local
%      function named CALLBACK in WORKINGGUI2.M with the given input arguments.
%
%      WORKINGGUI2('Property','Value',...) creates a new WORKINGGUI2 or raises the
%      existing singleton*.  Starting from the left, property value pairs are
%      applied to the GUI before WorkingGUI2_OpeningFcn gets called.  An
%      unrecognized property name or invalid value makes property application
%      stop.  All inputs are passed to WorkingGUI2_OpeningFcn via varargin.
%
%      *See GUI Options on GUIDE's Tools menu.  Choose "GUI allows only one
%      instance to run (singleton)".
%
% See also: GUIDE, GUIDATA, GUIHANDLES

% Edit the above text to modify the response to help WorkingGUI2

% Last Modified by GUIDE v2.5 17-Sep-2019 15:09:28

% Begin initialization code - DO NOT EDIT
gui_Singleton = 1;
gui_State = struct('gui_Name',       mfilename, ...
                   'gui_Singleton',  gui_Singleton, ...
                   'gui_OpeningFcn', @WorkingGUI2_OpeningFcn, ...
                   'gui_OutputFcn',  @WorkingGUI2_OutputFcn, ...
                   'gui_LayoutFcn',  [] , ...
                   'gui_Callback',   []);
if nargin && ischar(varargin{1})
    gui_State.gui_Callback = str2func(varargin{1});
end

if nargout
    [varargout{1:nargout}] = gui_mainfcn(gui_State, varargin{:});
else
    gui_mainfcn(gui_State, varargin{:});
end
% End initialization code - DO NOT EDIT


% --- Executes just before WorkingGUI2 is made visible.
function WorkingGUI2_OpeningFcn(hObject, eventdata, handles, varargin)
% This function has no output args, see OutputFcn.
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)
% varargin   command line arguments to WorkingGUI2 (see VARARGIN)

% Choose default command line output for WorkingGUI2
handles.output = hObject;

% Update handles structure
guidata(hObject, handles);

% UIWAIT makes WorkingGUI2 wait for user response (see UIRESUME)
% uiwait(handles.figure1);


% --- Outputs from this function are returned to the command line.
function varargout = WorkingGUI2_OutputFcn(hObject, eventdata, handles) 
% varargout  cell array for returning output args (see VARARGOUT);
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)

% Get default command line output from handles structure
varargout{1} = handles.output;

%Begin Script
delete(instrfind('Port', 'COM3')); 
tag = serial('COM3'); %check which port is used
fopen(tag);
BOX = char(zeros(2,14)); 
i=1;
c=0;
TrueValueData = 'C:\Mastercodes.xlsx';
[~,~,TrueValMat] = xlsread(TrueValueData); % Creates matrix filled with the correct values, 
                                           % indexed by box, which is the first row
                                           % all proceeding rows are the master value

    for i=1:9223372036854775807
     if i>10 %first couple reads are filled with unicode nonsense, this skips that stage
     
     readData = fscanf(tag);
    if length(readData)>12
        
       BOX(str2num(readData(8)),1:14)= readData(11:24); % these numbers just give us what we want; 
                                                   % tags come in initially with some gobbledy-gook     
    end
            if strcmp(TrueValMat{2,1}, BOX(1,:))
            Reader1Correct;
          else 
            Reader1Incorrect;
          end
        
            if strcmp(TrueValMat{2,2}, BOX(2,:))
             Reader2Correct;
            else 
             Reader2Incorrect;
            end
            if strcmp(TrueValMat{2,1}, BOX(1,:))...
                    && strcmp(TrueValMat{2,2}, BOX(2,:)) == 1
                break
            end
     end
    end
 

% --- Executes during object creation, after setting all properties.
function uipanel1_CreateFcn(hObject, eventdata, handles1)
 function Reader1Correct
     set(handles1.uipanel1, 'BackgroundColor', 'g');
    end
    function Reader1Incorrect
        set(handles1.uipanel1, 'BackgroundColor', 'r');
    end
end

% hObject    handle to uipanel1 (see GCBO)
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    empty - handles not created until after all CreateFcns called


% --- Executes during object creation, after setting all properties.
function uipanel2_CreateFcn(hObject, eventdata, handles2)
function Reader2Correct
     set(handles2.uipanel2, 'BackgroundColor', 'g');
    end
    function Reader2Incorrect
        set(handles2.uipanel2, 'BackgroundColor', 'r');
    end
end
% hObject    handle to uipanel2 (see GCBO)
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    empty - handles not created until after all CreateFcns called
end
end
end

I don't know If have correctly made or called the functions in this script. I chnaged the handles monikor becasue I got a warning that it was used multiple times ( I don't know if that was necessary). When running the program, the GUI comes up jsut as I want it, but then get this error:

matlab.graphics.internal.figfile.FigFile/read>@(hObject,eventdata)WorkingGUI2('uipanel1_CreateFcn',hObject,eventdata,guidata(hObject)) 
Undefined function or variable 'WorkingGUI2_OutputFcn'.

Error in gui_mainfcn (line 264)
        feval(gui_State.gui_OutputFcn, gui_hFigure, [], gui_Handles);

Error in WorkingGUI2 (line 42)
    gui_mainfcn(gui_State, varargin{:});
 

I don't think I need any arguments output from WorkingGUI2_Outputfcn, but I am not sure.

thanks for any help

Answer 1

[Walter Roberson]

You have

function uipanel1_CreateFcn(hObject, eventdata, handles1)
 function Reader1Correct
     set(handles1.uipanel1, 'BackgroundColor', 'g');
    end
    function Reader1Incorrect
        set(handles1.uipanel1, 'BackgroundColor', 'r');
    end
end

That defines nested functions inside upanel1_CreateFcn (but does not call those functions.) It is not possible to define nested functions inside code that uses "function" without the matching "end" statement, so you would have had to add "end" statements to a number of places in the code.

But when you did that, you did not pay attention to the indentation, and you mis-nested. The "end" statement to terminate WorkingGUI2_OpeningFcn is not until much later, so several functions ended up nesting inside WorkingGUI2_OpeningFcn -- including WorkingGUI2_Outputfcn, so the reference to it in the OpenFcn cannot find it because it is not visible from the scope of the OpenFcn

Nested functions do not play well with GUIDE. Once you insert any nested function, then even if you manage to put all the "end" in at the correct places yourself, GUIDE can no longer manage the modified .m file.

If you need nested functions, then you should probably put the enclosing function into a different .m file, and the defining function should not be the direct target of a callback, and should instead be called from a callback.

[avram alter]

thats exactly what it was. and as you predicted, it immediately started throwing errors because of the nested functions.

I'll create the .m files to define the enclosed files, and then use the respective callback function, and see how it goes.

edit:

this is the current code:

function varargout = WorkingGUI2(varargin)
% WORKINGGUI2 MATLAB code for WorkingGUI2.fig
%      WORKINGGUI2, by itself, creates a new WORKINGGUI2 or raises the existing
%      singleton*.
%
%      H = WORKINGGUI2 returns the handle to a new WORKINGGUI2 or the handle to
%      the existing singleton*.
%
%      WORKINGGUI2('CALLBACK',hObject,eventData,handles,...) calls the local
%      function named CALLBACK in WORKINGGUI2.M with the given input arguments.
%
%      WORKINGGUI2('Property','Value',...) creates a new WORKINGGUI2 or raises the
%      existing singleton*.  Starting from the left, property value pairs are
%      applied to the GUI before WorkingGUI2_OpeningFcn gets called.  An
%      unrecognized property name or invalid value makes property application
%      stop.  All inputs are passed to WorkingGUI2_OpeningFcn via varargin.
%
%      *See GUI Options on GUIDE's Tools menu.  Choose "GUI allows only one
%      instance to run (singleton)".
%
% See also: GUIDE, GUIDATA, GUIHANDLES

% Edit the above text to modify the response to help WorkingGUI2

% Last Modified by GUIDE v2.5 17-Sep-2019 15:09:28

% Begin initialization code - DO NOT EDIT
gui_Singleton = 1;
gui_State = struct('gui_Name',       mfilename, ...
                   'gui_Singleton',  gui_Singleton, ...
                   'gui_OpeningFcn', @WorkingGUI2_OpeningFcn, ...
                   'gui_OutputFcn',  @WorkingGUI2_OutputFcn, ...
                   'gui_LayoutFcn',  [] , ...
                   'gui_Callback',   []);
if nargin && ischar(varargin{1})
    gui_State.gui_Callback = str2func(varargin{1});
end

if nargout
    [varargout{1:nargout}] = gui_mainfcn(gui_State, varargin{:});
else
    gui_mainfcn(gui_State, varargin{:});
end
% End initialization code - DO NOT EDIT


% --- Executes just before WorkingGUI2 is made visible.
function WorkingGUI2_OpeningFcn(hObject, eventdata, handles, varargin)
% This function has no output args, see OutputFcn.
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)
% varargin   command line arguments to WorkingGUI2 (see VARARGIN)

% Choose default command line output for WorkingGUI2
handles.output = hObject;

% Update handles structure
guidata(hObject, handles);

% UIWAIT makes WorkingGUI2 wait for user response (see UIRESUME)
% uiwait(handles.figure1);

end
% --- Outputs from this function are returned to the command line.
function varargout = WorkingGUI2_OutputFcn(hObject, eventdata, handles) 
% varargout  cell array for returning output args (see VARARGOUT);
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)

% Get default command line output from handles structure
varargout{1} = handles.output;
end
%Begin Script
delete(instrfind('Port', 'COM3')); 
tag = serial('COM3'); %check which port is used
fopen(tag);
BOX = char(zeros(2,14)); 
i=1;
c=0;
TrueValueData = 'C:\MasterCodes.xlsx';
[~,~,TrueValMat] = xlsread(TrueValueData); % Creates matrix filled with the correct values, 
                                           % indexed by box, which is the first row
                                           % all proceeding rows are the master value

    for i=1:9223372036854775807
     if i>10 %first couple reads are filled with unicode nonsense, this skips that stage
     
     readData = fscanf(tag);
    if length(readData)>12
        
       BOX(str2num(readData(8)),1:14)= readData(11:24); % these numbers just give us what we want; 
                                                   % tags come in initially with some gobbledy-gook     
    end
   
          if strcmp(TrueValMat{2,1}, BOX(1,:))
            R1C;
          else 
            R1I;
          end
        
            if strcmp(TrueValMat{2,2}, BOX(2,:))
             R2C;
            else 
             R2I;
            end
            if strcmp(TrueValMat{2,1}, BOX(1,:))...
                    && strcmp(TrueValMat{2,2}, BOX(2,:)) == 1
                break
            end
     end
    end
 global hObject1;
 global hObject2;
 global handles1;
 global handles2;

% --- Executes during object creation, after setting all properties.
function uipanel1_CreateFcn(hObject1, eventdata, handles1)
[R1C] = Reader1Correct(hObject1, handles1);
[R1I] = Reader1Incorrect(hObject1, handles1);
end
% hObject    handle to uipanel1 (see GCBO)
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    empty - handles not created until after all CreateFcns called


% --- Executes during object creation, after setting all properties.
function uipanel2_CreateFcn(hObject2, eventdata, handles2)
[R2C] = Reader2Correct(hObject2, handles2);
[R2I] = Reader2Incorrect(hObject2, handles2);
end
% hObject    handle to uipanel2 (see GCBO)
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    empty - handles not created until after all CreateFcns called
end

But I keep getting unitialized function errors:

Error in
matlab.graphics.internal.figfile.FigFile/read>@(hObject,eventdata)WorkingGUI2('uipanel1_CreateFcn',hObject,eventdata,guidata(hObject)) 
Undefined function or variable 'R1I'.

Error in WorkingGUI2 (line 100)
            R1I;
 

even though I thought I initilialzied them in the function header. Reader1Correct, and the others are the names of .m files which have this same function, more or less:

            function Reader2Incorrect(hObject2, handles2)
    set(handles2.uipanel2, 'BackgroundColor', 'r');
end

with the handles number and color set differing depending on which color I need.

[Walter Roberson]

http://matlab.wikia.com/wiki/FAQ#How_can_I_share_data_between_callback_functions_in_my_GUI.28s.29.3F

[avram alter]

I added my handles and hObjects as global variables, but I am not getting any different results.

[Walter Roberson]

function uipanel1_CreateFcn(hObject1, eventdata, handles1)
  handles.R1C = @Reader1Correct;
  handles.R1I = @Reader1Incorrect;
  guidata(hObject1);
  
function uipanel2_CreateFcn(hObject2, eventdata, handles2)
   handles.R2C = @Reader2Correct;
   handles.R2I = @Reader2Incorrect;
   guidata(hObject2);

function varargout = WorkingGUI2_OutputFcn(hObject, eventdata, handles) 
   bunch of lines here
   
   if strcmp(TrueValMat{2,1}, BOX(1,:))
      handles.R1C(hObject, handles);
   else 
      handles.R1I(hObject, handles);
   end
        
   if strcmp(TrueValMat{2,2}, BOX(2,:))
     handles.R2C(hObject, handles);
   else 
     handles.R2I(hObject, handles);
   end

Notice the lack of global variables.

I would not code things this way unless I had particular reason to. I would leave out those two _CreateFcn and just use

   function varargout = WorkingGUI2_OutputFcn(hObject, eventdata, handles) 
   bunch of lines here
   
   if strcmp(TrueValMat{2,1}, BOX(1,:))
      Reader1Correct(hObject, handles);
   else 
      Reader1Incorrect(hObject, handles);
   end
        
   if strcmp(TrueValMat{2,2}, BOX(2,:))
     Reader2Correct(hObject, handles);
   else 
     Reader2Incorrect(hObject, handles);
   end

[avram alter]

thanks for this answer. is there any way to dynamically chnage which uipanel I am dealing with? instead of writing 16 if/else statements, which is what my finished product will need, is htere a way to chnage which uipanel i am dealing with in a single loop?

for example

BOX = char(zeros(2,14));
UNSCANNEDBOX = char(zeros(1,14));
TrueValueData = 'C:\Values.xlsx';
[~,~,TrueValMat] = xlsread(TrueValueData);
for n = 1:16
    if strcmp(BOX(n,:), BOXUNSCANNED) == 0
        if strcmp(TrueValMat{2,n}, BOX(n,:))
            set(handles.uipanel(n), 'BackgroundColor', 'g') 
        else 
            % change color to red
        end
    end
end

in the line that chnages the backgrounbd color, notice how after uipanel is (n), to call eacxh successive panel as it come up. would this work? or is there a way to do that?

[Walter Roberson]

Yes. In your GUI opening fcn, WorkingGUI2_OpeningFcn, before the existing line that sets the output, add

handles.uipanels = [handles.uipanel1, handles.uipanel2, handles.uipanel3 and so on handles.uipanel16];

Then

BOX = char(zeros(2,14));
UNSCANNEDBOX = char(zeros(1,14));
TrueValueData = 'C:\Values.xlsx';
[~,~,TrueValMat] = xlsread(TrueValueData);
for n = 1:16
    if strcmp(BOX(n,:), BOXUNSCANNED) == 0
        if strcmp(TrueValMat{2,n}, BOX(n,:))
            set(handles.uipanels(n), 'BackgroundColor', 'g') 
        else 
            set(handles.uipanels(n), 'BackgroundColor', 'r') 
        end
    end
end

[avram alter]

If I do that, the script almost immediately stops. how do I get it to continue looping from 1:16, until all the strcmp() == 1?

edit: I nested another for loop, so now it runs as long as I need, however, nothing actually happens. this is the code I have:

%leaving off some initialization lines

function WorkingGUI3_OpeningFcn(hObject, eventdata, handles, varargin)
% This function has no output args, see OutputFcn.
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)
% varargin   command line arguments to WorkingGUI3 (see VARARGIN)
handles.uipanels = [handles.uipanel1, handles.uipanel2];
% Choose default command line output for WorkingGUI3
handles.output = hObject;

% Update handles structure
guidata(hObject, handles);

% UIWAIT makes WorkingGUI3 wait for user response (see UIRESUME)
% uiwait(handles.figure1);

end
% --- Outputs from this function are returned to the command line.
function varargout = WorkingGUI3_OutputFcn(hObject, eventdata, handles)
delete(instrfind('Port', 'COM3')); 
tag = serial('COM3'); %check which port is used
fopen(tag);
%untitled3;
BOX = char(zeros(2,14)); 
BoxUnscanned = char(zeros(1, 14));
TrueValueData = 'C:\Values.xlsx';
[~,~,TrueValMat] = xlsread(TrueValueData);
% Creates matrix filled with the correct values, 
% indexed by box, which is the first row
% all proceeding rows are the master value
for j=1:inf
 for n = 1:2
     if j>10
         readData = fscanf(tag);
         if length(readData)>12
             BOX(str2num(readData(8)),1:14)= readData(11:24); 
     if strcmp(BOX(n,:), BoxUnscanned) == 0
             if strcmp(TrueValMat{2,n}, BOX(n,:)) 
                 set(handles.uipanels(n), 'BackgroundColor', 'g');
             else 
                set(handles.uipanels(n), 'BackgroundColor', 'r');
             end
     end
 end
     end
 end
end
% varargout  cell array for returning output args (see VARARGOUT);
% hObject    handle to figure
% eventdata  reserved - to be defined in a future version of MATLAB
% handles    structure with handles and user data (see GUIDATA)

% Get default command line output from handles structure
varargout{1} = handles.output;
end
end

[Walter Roberson]

Remember to put in a drawnow()

[avram alter]

thanks for all the help, this would not have gotten done without you. quick question, I want to have multiple com ports, they don't have to be simulataneous, just one after another. how would I do this?

[Walter Roberson]

If you have multiple com ports then I would recommend that you use BytesAvailableFcn callbacks on the serial ports instead of polling them.

It is certainly possible to do something like

p{1} = serial('COM2');
p{2} = serial('COM7');

for K = 1 : length(p)
    buf{K} = fgetl(p{K});
end

to read lines from each port in turn. The difficulty with that is that if one of the ports has not sent anything, then this code will sit and wait around until that port gets around to sending a line -- and in the meantime all of the other ports might have sent multiple lines. BytesAvailableFcn callbacks on the other hand are run as soon as practical after MATLAB notices that a line is completely available from the serial port, so if one port sends lines (say) 4 times faster, then there is no problem.

[avram alter]

ech one of the serial ports I will have will loop constantly at 9600 baud. I dont think i will have to wait for any particular serial port more than anything else. how would you implement your buffering code? I attmepted to replace my tag(serial) statements to what you wrote, But it didnt work. how would I use that?